[PATCH] D12608: [RewriteStatepointsForGC] Strengthen invariants around BDVs

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with minor nits addressed.


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:296
@@ +295,3 @@
+/// transition between vector and scalar types, there is no immediate base
+/// defining value.  The 'base defining value' for 'Def' is the transative
+/// closure of this relation stopping at the first instruction which has no
----------------
Nit: should be `transitive`.

================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:310
@@ +309,3 @@
+    // a base.
+    bool MustBeBase = isKnownBaseResult(BDV);
+    assert(!MustBeBase || MustBeBase == IsKnownBase);
----------------
I'd put `isKnownBaseResult` inside an `#ifndef NDEBUG`, otherwise you're computing `isKnownBaseResult` and throwing it away in non-asserts builds.


http://reviews.llvm.org/D12608