[PATCH] D12605: [ELF2] Don't allocate more SymbolBodies than needed.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 13:19:12 PDT 2015


LGTM. Thanks!

On 3 September 2015 at 16:14, Davide Italiano <dccitaliano at gmail.com> wrote:
> davide created this revision.
> davide added reviewers: rafael, Bigcheese.
> davide added a subscriber: llvm-commits.
>
> We're aiming  at not wasting space, but let's try to do it properly (hopefully).
>
> http://reviews.llvm.org/D12605
>
> Files:
>   ELF/InputFiles.cpp
>
> Index: ELF/InputFiles.cpp
> ===================================================================
> --- ELF/InputFiles.cpp
> +++ ELF/InputFiles.cpp
> @@ -110,7 +110,7 @@
>    if (FirstNonLocal > NumSymbols)
>      error("Invalid sh_info in symbol table");
>    Syms = llvm::make_range(Syms.begin() + FirstNonLocal, Syms.end());
> -  SymbolBodies.reserve(NumSymbols);
> +  SymbolBodies.reserve(NumSymbols - FirstNonLocal);
>    for (const Elf_Sym &Sym : Syms)
>      SymbolBodies.push_back(createSymbolBody(StringTable, &Sym));
>  }
>
>


More information about the llvm-commits mailing list