[PATCH] D10674: Value profiling - patchset 3

[Betul Buyukkurt via llvm-commits]

betulb updated this revision to Diff 33963.
betulb added a comment.

In this revision:

- Turned the error to assert for "hash value not matching any known key"
- Used rvalue-reference semantics when passing arguments into the InstrProfWriter's addRecord routine. String table usage caused the undesirable removal of const qualifier from addRecord's argument. Now the arguments to addRecord are clearly passed using std::move()
- In combineInstrProfRecords, tried to account for when value profiling is not enabled for a given kind for Source vs enabled for Dest and vice versa.
- Used std::vector's empty() instead of comparing size() against 0


http://reviews.llvm.org/D10674

Files:
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfIndexed.h
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/CoverageMappingTest.cpp
  unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10674.33963.patch
Type: text/x-patch
Size: 28086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150903/16a62082/attachment.bin>