[PATCH] D12023: Test triangle inheritance member poisoning

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: test/msan/dtor-bit-fields.cc:1
@@ +1,2 @@
+// RUN: %clangxx_msan %s -O0 -fsanitize=memory -fsanitize-memory-use-after-dtor -o %t && MSAN_OPTIONS=poison_in_dtor=1 %run %t >%t.out 2>&1
+
----------------
Please remove this in all new tests:
>%t.out 2>&1

This is not needed when not running FileCheck, and can make failure logs less verbose.

================
Comment at: test/msan/dtor-bit-fields.cc:23
@@ +22,3 @@
+  unsigned int e : 1;
+  ~Packed() {}
+};
----------------
Add a TODO to remove these empty destructors once the problem is fixed.

================
Comment at: test/msan/dtor-bit-fields.cc:48
@@ +47,3 @@
+  Packed p;
+  p.~Packed();
+  for (int i = 0; i < 4; i++)
----------------
UB, a destructor is called twice.



http://reviews.llvm.org/D12023