[lld] r246780 - COFF: Ignore /GUARDSYM option.

[Rui Ueyama via llvm-commits]

On Fri, Sep 4, 2015 at 1:29 AM, Davide Italiano <davide at freebsd.org> wrote:

> On Thu, Sep 3, 2015 at 9:20 AM, Rui Ueyama via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: ruiu
> > Date: Thu Sep  3 11:20:47 2015
> > New Revision: 246780
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=246780&view=rev
> > Log:
> > COFF: Ignore /GUARDSYM option.
> >
> > The option is added in MSVC 2015, and there's no documentation about
> > what the option is. This patch is to ignore the option for now, so that
> > at least LLD is usable with MSVC 2015.
> >
> > Modified:
> >     lld/trunk/COFF/Driver.cpp
> >     lld/trunk/COFF/Options.td
> >
> > Modified: lld/trunk/COFF/Driver.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=246780&r1=246779&r2=246780&view=diff
> >
> ==============================================================================
> > --- lld/trunk/COFF/Driver.cpp (original)
> > +++ lld/trunk/COFF/Driver.cpp Thu Sep  3 11:20:47 2015
> > @@ -120,6 +120,7 @@ void LinkerDriver::parseDirectives(Strin
> >        Config->NoDefaultLibs.insert(doFindLib(Arg->getValue()));
> >        break;
> >      case OPT_editandcontinue:
> > +    case OPT_guardsym:
> >      case OPT_throwingnew:
> >        break;
> >      default:
> >
>
> Can we emit some kind of diagnostic to let the user know we're ignoring
> these?
>

We could, but it would be annoying because the option is present in
.drectve sections of object files, and users are not aware of the presence
of the option.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150904/2bcfa1ca/attachment.html>