[PATCH] D12581: [MergeFuncs] Fix callsite attributes in thunk generation

[JF Bastien via llvm-commits]

jfb added inline comments.

================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:1558
@@ +1557,3 @@
+      // etc. No code actually looks up attributes from the called function,
+      // because then it would fail on indirect calls.
+
----------------
Why would non-null be missing? Could you add a test that shows this?

I'm not sure I get why the bitcast is needed here, and why you can't just drop the comment. It looks like it's there to match parameters/returns that are layout compatible but have different names. Why not cast those, instead of the function signature?


http://reviews.llvm.org/D12581