[PATCH] D12455: [IR] Teach `llvm::User` to co-allocate a descriptor.

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 15:30:32 PDT 2015


> On Sep 2, 2015, at 3:20 PM, Sanjoy Das <sanjoy at playingwithpointers.com> wrote:
> 
> sanjoy added a comment.
> 
> @pete - can you please take a look to see if you're okay with how I've specialized `operator new`?
The implementation generally looks good with just one question.

Can you check to see if allocateFixedOperandUser can just be static inline in User.cpp and avoid the declaration in User.h?

Otherwise LGTM.

Thanks,
Pete
> 
> 
> https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12455&d=BQIFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=Xw5go3ocA3WFS9VUceYGLOtQZatFzfVq0EIKS_CkaaY&s=7bd4hN0eD59OPZIU3JMqMub6oRpT45d4V4D6bIWGGTo&e= 
> 
> 
> 



More information about the llvm-commits mailing list