[PATCH] D12094: Avoid the propagation of debug locations in SelectionDAG via CSE

Wolfgang Pieb via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 11:55:49 PDT 2015


wolfgangp updated this revision to Diff 33837.
wolfgangp added a comment.

Given the concerns about nulling out the debug location here is a different attempt: We determine from the context whether the place where the node is reused is located earlier in the sequence of instructions. To this end we're using the SDNodes' IROrder which reflects the sequence of IR instructions. This required adjustment of the interface of FindNodeOrInsertPos() because we need an SDLoc instead of just a DebugLoc.

Sergey, I wasn't sure if we can subsume Constant nodes under this change, but it seemed that it's still better to null out the DebugLocation in those cases.


http://reviews.llvm.org/D12094

Files:
  include/llvm/CodeGen/SelectionDAG.h
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  test/DebugInfo/isel-cse-line.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12094.33837.patch
Type: text/x-patch
Size: 15831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150902/bc430f39/attachment.bin>


More information about the llvm-commits mailing list