[PATCH] D12545: [elf2] Add basic archive file support.

[Rafael Espíndola via llvm-commits]

The test seems to do a bit more than what is needed:

* Why do you need to disassemble?
* _start is already undefined at the start of the link, you shouldn't
need to introduce a new undefined reference to it just to fetch the
member.


On 2 September 2015 at 11:20, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added a subscriber: rafael.
> rafael added a comment.
>
> The patch is not git-clang-format clean
>
> building I get these warnings:
>
> /home/espindola/llvm/llvm/tools/lld/ELF/Driver.cpp:83:11: warning:
> enumeration value 'ArchiveKind' not handled in switch [-Wswitch]
>
>   switch (FirstObj.kind()) {
>           ^
>
> 1 warning generated.
> [6/8] Building CXX object tools/lld/ELF/CMakeFiles/lldELF2.dir/SymbolTable.cpp.o
> /home/espindola/llvm/llvm/tools/lld/ELF/SymbolTable.cpp:46:13:
> warning: enumeration value 'ArchiveKind' not handled in switch
> [-Wswitch]
>
>   switch (File->kind()) {
>           ^
>
> /home/espindola/llvm/llvm/tools/lld/ELF/SymbolTable.cpp:64:13:
> warning: enumeration value 'ArchiveKind' not handled in switch
> [-Wswitch]
>
>   switch (File->kind()) {
>           ^
>
> 2 warnings generated.
> [6/8] Building CXX object tools/lld/ELF/CMakeFiles/lldELF2.dir/Writer.cpp.o
> /home/espindola/llvm/llvm/tools/lld/ELF/Writer.cpp:317:13: warning:
> enumeration value 'LazyKind' not handled in switch [-Wswitch]
>
>   switch (Body->kind()) {
>           ^
>
> /home/espindola/llvm/llvm/tools/lld/ELF/Writer.cpp:317:13: warning:
> enumeration value 'LazyKind' not handled in switch [-Wswitch]
> /home/espindola/llvm/llvm/tools/lld/ELF/Writer.cpp:317:13: warning:
> enumeration value 'LazyKind' not handled in switch [-Wswitch]
> /home/espindola/llvm/llvm/tools/lld/ELF/Writer.cpp:317:13: warning:
> enumeration value 'LazyKind' not handled in switch [-Wswitch]
> /home/espindola/llvm/llvm/tools/lld/ELF/Writer.cpp:317:13: warning:
> enumeration value 'LazyKind' not handled in switch [-Wswitch]
>
>
> http://reviews.llvm.org/D12545
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits