[PATCH] D11219: [mips][microMIPS] Implement JALRC16, JRCADDIUSP and JRC16 instructions

[Daniel Sanders via llvm-commits]

dsanders added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:974
@@ +973,3 @@
+    int64_t val = getConstantImm();
+    return val >= 0 && val <= 32;
+  }
----------------
mpf wrote:
> dsanders wrote:
> > This doesn't sound right. uimm5 is indeed 0-32 but nothing accounts for the Lsl2 part of the name.
> > 
> > Shouldn't this be testing for multiples of 4 between 0 and 128?
> Don't you mean 0-31 inclusive? and therefore 0->124 inclusive in multiples of 4?
Yes, sorry for the ambiguity.


http://reviews.llvm.org/D11219