[lld] r246621 - COFF: Attempt to fix a flaky test.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Wed Sep  2 03:10:37 2015
New Revision: 246621

URL: http://llvm.org/viewvc/llvm-project?rev=246621&view=rev
Log:
COFF: Attempt to fix a flaky test.

I don't understand why the previous code is pretty flaky and
the new code is at least less flaky, but the original test
occasionally failed on the second run of lib.exe.

My guess was that lib.exe was failing because the output of
the echo command executed immediately before lib.exe was not
flushed to a file, but as far as I can say, the file
descriptor is properly closed in TestRunner.py, so this's
probably not correct. Other theory is that, on Windows, file
output is not guaranteed to be visible to other processes even
if a process flushes file descriptors, but I'd think that's
unlikely. So honestly I don't know the cause yet.

Modified:
    lld/trunk/test/COFF/dllorder.test

Modified: lld/trunk/test/COFF/dllorder.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/dllorder.test?rev=246621&r1=246620&r2=246621&view=diff
==============================================================================
--- lld/trunk/test/COFF/dllorder.test (original)
+++ lld/trunk/test/COFF/dllorder.test Wed Sep  2 03:10:37 2015
@@ -6,10 +6,9 @@
 # RUN: rm -f %tlib/lib2.lib
 
 # RUN: echo EXPORTS sym1 > %t1.def
-# RUN: lib /nologo /machine:amd64 /def:%t1.def /out:%tlib\\lib1.lib > /dev/null
-
 # RUN: echo EXPORTS sym2 > %t2.def
-# RUN: lib /nologo /machine:amd64 /def:%t2.def /out:%tlib\\lib2.lib > /dev/null
+# RUN: lib /nologo /machine:amd64 /def:%t1.def /out:%tlib\lib1.lib
+# RUN: lib /nologo /machine:amd64 /def:%t2.def /out:%tlib\lib2.lib
 
 # RUN: lld-link /out:%t1.exe /entry:main /libpath:%tlib %t.obj /defaultlib:lib1 /defaultlib:lib2
 # RUN: lld-link /out:%t2.exe /entry:main /libpath:%tlib %t.obj /defaultlib:lib2 /defaultlib:lib1