[PATCH] D12226: [LLD] Support for --unresolved-symbols option in llvm lld for ELF file format

[Rui Ueyama via llvm-commits]

ruiu added a subscriber: ruiu.

================
Comment at: lib/Driver/GnuLdDriver.cpp:439-442
@@ +438,6 @@
+    }
+    else if (val.compare("ignore-all") &&
+             val.compare("report-all") &&
+             val.compare("ignore-in-object-files") &&
+             val.compare("ignore-in-shared-libs")) {
+
----------------
It's better to define enums for these strings and use them in Resolver.cpp instead of strings.

================
Comment at: lib/Driver/GnuLdDriver.cpp:458
@@ +457,3 @@
+    ctx->setPrintRemainingUndefines(true);
+    ctx->setAllowRemainingUndefines(false);
+  }
----------------
I'm wondering if this is correct. Does --unresolved-symbols really negate --allow-shlib-undefines?


http://reviews.llvm.org/D12226