[PATCH] D12475: [LV] Pull creation of trip counts into a helper function.

[Michael Zolotukhin via llvm-commits]

mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.

Provided the spotted issues are fixed, the patch LGTM. Thanks, James!

Michael


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2763
@@ +2762,3 @@
+
+  Builder.SetInsertPoint(VectorPH->getTerminator());
+  StartIdx = ConstantInt::get(IdxTy, 0);
----------------
This is still the issue:)

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2770
@@ -2733,3 +2769,3 @@
   // inside the loop.
   Builder.SetInsertPoint(VecBody->getFirstNonPHI());
 
----------------
Here it's overwritten before any use. One of these two `SetInsertPoint`s is redundant.


Repository:
  rL LLVM

http://reviews.llvm.org/D12475