[PATCH] D12456: [IR] Add operand bundles to CallInst and InvokeInst.

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 17:58:03 PDT 2015


JosephTremoulet added inline comments.

================
Comment at: include/llvm/IR/Instructions.h:1429
@@ +1428,3 @@
+        unsigned(Args.size()) + CountBundleInputs(Bundles) + 1;
+    const unsigned DescriptorBytes = Bundles.size() * sizeof(BundleOpInfo);
+
----------------
I agree with your math.  I think leaving `Begin` and `End` as `uint32_t` makes sense; I doubt this would be the only weak link if someone tried to put 2^32 operands on a call, and even if we were to run on a platform with an odd pointer size, I'd expect sizeof(BundleOpInfo) to be a multiple of it by virtue of the Tag pointer field.


http://reviews.llvm.org/D12456





More information about the llvm-commits mailing list