[PATCH] D12506: Distinguish "native" from "native-arch" in lit testing

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 12:58:10 PDT 2015


probinson added a comment.

In http://reviews.llvm.org/D12506#237410, @joker.eph wrote:

> For instance, I just tried to configure the default target triple to "amdgcn--amdhsa" and configure in the X86 and AMDGPU backends. Running `ninja check` yields 202 failures.


Yes, but I just tried an ARM-backend-only configuration (r243957, prior to your changes) running on X86, default triple "armv7a--linux" and running 'ninja check' yielded NO failures.  So I think your issues have more to do with GPU backends not being general-purpose, rather than the host-arch not being one of the available targets.  You have applied too big a hammer to the problem, and turned off testing configurations that are actually valuable.

I think Takumi is correct, this needs to be discussed on the dev list.  I am unlikely to have time to write up a proper description today so if you want to, go ahead; if you don't I will probably get to it tomorrow.


http://reviews.llvm.org/D12506





More information about the llvm-commits mailing list