[PATCH] D12488: Enable linking tools, shared libraries against libLLVM

[NAKAMURA Takumi via llvm-commits]

chapuni added inline comments.

================
Comment at: cmake/modules/AddLLVM.cmake:44
@@ -43,3 +43,3 @@
   #   - PROPERTY COMPILE_FLAGS is string.
-  string(REPLACE ";" " " target_compile_flags "${LLVM_COMPILE_FLAGS}")
+  string(REPLACE ";" " " target_compile_flags " ${LLVM_COMPILE_FLAGS}")
 
----------------
axw wrote:
> chapuni wrote:
> > Is it relevant to your changes?
> > FYI, it triggers recompilation of whole files (on ninja).
> > Is it relevant to your changes?
> 
> This was to fix a bug I found while making my changes. In some cases, COMPILE_FLAGS did not end with whitespace, so argument lists were being concatenated badly.
> 
> > FYI, it triggers recompilation of whole files (on ninja).
> 
> Once only, right? Is that a problem?
> Once only, right? Is that a problem?

Once. Let it not reverted if it fixed your issue.


http://reviews.llvm.org/D12488