[PATCH] D12457: [Bitcode][Asm] Teach LLVM to read and write operand bundles.

[Sanjoy Das via llvm-commits]

sanjoy added inline comments.

================
Comment at: lib/AsmParser/LLParser.cpp:1954
@@ +1953,3 @@
+
+    auto ParseOperandBundle = [&]() {
+      std::string Tag;
----------------
JosephTremoulet wrote:
> Why use a lambda here as opposed to just inlining it?
I started out thinking that the early returns would simplify the code, but after re-reading it I don't think they're helping at all.  I'll inline the logic and get rid of the lambda.

================
Comment at: test/Bitcode/operand-bundles.ll:19
@@ +18,3 @@
+ entry:
+; The operand bundle set [] is equivalent to "no operand bundles"
+  call void @callee0() [ ]
----------------
JosephTremoulet wrote:
> Do we really want two ways to represent that?  I think reporting an error for [ ] would be appropriate.
Will fix.


http://reviews.llvm.org/D12457