[PATCH] D11847: [BasicAA] Fix zext & sext handling
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 31 15:04:46 PDT 2015
Hi Nick,
I was looking into why this patch was introducing other problems and I think it boils down to I’ve screwed up my rebase of this patch.
Doing it again from scratch (after reverting my revert r245394) seems to yield correct code.
I am going to push your changes.
I let you know which revision it is so that you can double check that I did not screw up again!
Thanks,
-Quentin
> On Aug 19, 2015, at 2:12 PM, Nicholas White <n.j.white at gmail.com> wrote:
>
> Hi - sorry I haven't had time to address Hal's review comments yet,
> and thanks for the additional test case Quentin. This patch (or as you
> pointed out, series of edits to the sext / zext code) is only intended
> to fix outstanding bugs, not add any new functionality. It'd be good
> if this gets into 3.7 but the bugs it fixes are in the 3.6 release and
> aren't causing too much pain - and touching this part of the codebase
> has a lot of downstream consequences. Thanks -
>
> Nick
More information about the llvm-commits
mailing list