[llvm] r246491 - Revert "[lit] Speculatively fix PR24554 by manually closing the process handle"

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 14:42:02 PDT 2015


Author: rnk
Date: Mon Aug 31 16:42:02 2015
New Revision: 246491

URL: http://llvm.org/viewvc/llvm-project?rev=246491&view=rev
Log:
Revert "[lit] Speculatively fix PR24554 by manually closing the process handle"

This reverts commit r245946. It didn't help the problem:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9179/steps/run%20tests/logs/stdio
LINK : fatal error LNK1104: cannot open file

Modified:
    llvm/trunk/utils/lit/lit/TestRunner.py

Modified: llvm/trunk/utils/lit/lit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=246491&r1=246490&r2=246491&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Aug 31 16:42:02 2015
@@ -257,9 +257,6 @@ def executeShCmd(cmd, shenv, results):
     exitCode = None
     for i,(out,err) in enumerate(procData):
         res = procs[i].wait()
-        # On Windows, manually close the process handles.
-        if kIsWindows:
-            procs[i]._handle.Close()
         # Detect Ctrl-C in subprocess.
         if res == -signal.SIGINT:
             raise KeyboardInterrupt




More information about the llvm-commits mailing list