[PATCH] D12493: Do Not Model Unbounded Loops

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 12:12:05 PDT 2015


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Basically OK, but:

1. I think we are far away from allowing anything unbounded so I don't think we need the flag but can just bail out. (If I am wrong please correct me)
2. This part of the code generation is broken. Not only the unbounded part but even the SCEV trip count part that has been there for years. I currently write the second part of the isl domain patch that uses a completly different approach to build the domain. So far it showed that ~5 of our unit tests have the wrong domaing

Summary: I can push this in with or without the flag (tell me what you prefere) but I don't think it will last long.

P.S. You should get commiter access.


http://reviews.llvm.org/D12493





More information about the llvm-commits mailing list