[llvm] r246352 - Revert r246350, "The host and default target triples do not need to match for "native""

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 17:29:25 PDT 2015


See my comments in D12454.  I think we do want both predicates: native environment, and native architecture.
It looks like "native" was always intended to mean "native environment" so for Mehdi's needs we should invent a new feature and leave "native" as it was.
--paulr

From: NAKAMURA Takumi [mailto:geek4civic at gmail.com]
Sent: Friday, August 28, 2015 5:16 PM
To: Mehdi Amini
Cc: llvm-commits at lists.llvm.org; Robinson, Paul
Subject: Re: [llvm] r246352 - Revert r246350, "The host and default target triples do not need to match for "native""

Seems I forgot to update comments in r193459.
I assume "native" means "targeting for native environment, (not architecture)"
I am afraid if we, each other, were misunderstanding "native".

If "native" might be "native architecture", I would have to introduce a yet another feature like "jit".

FYI, I am reverting your r243960 in my local build tree.

On Sat, Aug 29, 2015 at 8:41 AM Mehdi Amini <mehdi.amini at apple.com<mailto:mehdi.amini at apple.com>> wrote:

> On Aug 28, 2015, at 4:33 PM, NAKAMURA Takumi via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
>
> Author: chapuni
> Date: Fri Aug 28 18:33:17 2015
> New Revision: 246352
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246352&view=rev
> Log:
> Revert r246350, "The host and default target triples do not need to match for "native""
>
> Wrong assumption. Consider --host=x86_64-linux --target=(i686|x86_64)-win32. See also r193459.

Please elaborate how it impacts the tests.

This needs to be better documented in the code itself as well.


Thanks,

Mehdi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150829/111c5216/attachment.html>


More information about the llvm-commits mailing list