[PATCH] D12440: [BitcodeReader] Ensure we can read constant vector selects with an i1 condition

[Filipe Cabecinhas via llvm-commits]

True. I'll fix it later today.

Thanks,

 Filipe

On Friday, August 28, 2015, Karl Schimpf <kschimpf at google.com> wrote:

> kschimpf added a subscriber: kschimpf.
>
> ================
> Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:2482
> @@ +2481,3 @@
> +          if (SelectorTy != V->getType())
> +            SelectorTy = VectorType::get(Type::getInt1Ty(Context),
> +                                         VTy->getNumElements());
> ----------------
> Out of curiosity, why not use SelectorTy instead of
> Type::getInt1Ty(Context), since you have already computed it?
>
>
> http://reviews.llvm.org/D12440
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150828/239219d7/attachment.html>