[PATCH] D12335: Repress sanitization on User dtor.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: include/llvm/IR/Metadata.h:769
@@ -768,3 +768,3 @@
          ArrayRef<Metadata *> Ops1, ArrayRef<Metadata *> Ops2 = None);
-  ~MDNode() = default;
+  LLVM_NO_SANITIZE_MEMORY_ATTRIBUTE ~MDNode() = default;
 
----------------
Maybe move this to MDNode::operator delete, the same as with User?

================
Comment at: include/llvm/IR/User.h:76
@@ +75,3 @@
+  // Repress memory sanitization, due to use-after-destroy by operator
+  // delete. Bug report 24578 identifies this issue.
+  ~User() override {}
----------------
Now this comment does not make sense. Move it to operator delete.


http://reviews.llvm.org/D12335