[PATCH] D12443: VirtRegMap: Improve addMBBLiveIns() using SlotIndex::MBBIndexIterator; NFC

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 11:44:46 PDT 2015


MatzeB created this revision.
MatzeB added a reviewer: qcolombet.
MatzeB added subscribers: atrick, llvm-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: MatzeB.

Now that we have an explicit iterator over the idx2MBBMap in SlotIndices
we can use the fact that segments and the idx2MBBMap are sorted by
SlotIndex position. We can advance both simultaneously instead of
starting from the beginning for each segment.

This complicates the code for the subregister case somewhat because we have to
keep a set of iterators for each subrange in sync. The result should however be
more efficient and has the advantage that we get the complete lanemask for each
block immediately instead of incrementally building it. This is important for a
subsequent change.

Removes the now unused SlotIndexes::findMBBLiveIns function.

Repository:
  rL LLVM

http://reviews.llvm.org/D12443

Files:
  include/llvm/CodeGen/LiveIntervalAnalysis.h
  include/llvm/CodeGen/SlotIndexes.h
  lib/CodeGen/VirtRegMap.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12443.33451.patch
Type: text/x-patch
Size: 5956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150828/c6425180/attachment.bin>


More information about the llvm-commits mailing list