[llvm] r246269 - Tweak XFAIL line for mips.

[Daniel Sanders via llvm-commits]

Hi,

This commit brushes against a Mips-specific quirk that I ought to mention in case the change isn't quite what you intended. lit checks whether the given string is a substring of the triple. As a result, 'mips' covers both 'mips' and 'mipsel' (as well as 'mips64' and 'mips64el'). A trailing dash is used to prevent accidentally matching all of them when you only meant to match a specific case.

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Peter Collingbourne via llvm-commits
> Sent: 28 August 2015 05:08
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r246269 - Tweak XFAIL line for mips.
> 
> Author: pcc
> Date: Thu Aug 27 23:07:52 2015
> New Revision: 246269
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=246269&view=rev
> Log:
> Tweak XFAIL line for mips.
> 
> Modified:
>     llvm/trunk/test/LTO/X86/parallel.ll
> 
> Modified: llvm/trunk/test/LTO/X86/parallel.ll
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/test/LTO/X86/parallel.ll?rev=246269&r1=246268&r2=2462
> 69&view=diff
> ==========================================================
> ====================
> --- llvm/trunk/test/LTO/X86/parallel.ll (original)
> +++ llvm/trunk/test/LTO/X86/parallel.ll Thu Aug 27 23:07:52 2015
> @@ -4,7 +4,7 @@
>  ; RUN: llvm-nm %t.o.1 | FileCheck --check-prefix=CHECK1 %s
> 
>  ; FIXME: Investigate test failures on these architecures.
> -; XFAIL: mips-, mipsel-, aarch64
> +; XFAIL: mips, mipsel, aarch64
> 
>  target triple = "x86_64-unknown-linux-gnu"
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits