[PATCH] D11725: [DependenceAnalysis] Ensure All Recurrences are Affine

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 23:58:39 PDT 2015


sanjoy added a comment.

In http://reviews.llvm.org/D11725#234430, @mssimpso wrote:

> If you're asking why the divide function gives up on some cases (appropriately setting the quotient to be zero and the remainder to be the original dividend) and instead asserts on the non-affine add rec case, I think that's a valid point. Does it make sense to quietly give up here instead of asserting?


As someone who does not know the details of DependenceAnalysis, I'd say yes.  That makes the behavior consistent between non-affine add recurrences and other SCEV expressions that cannot be divided.


http://reviews.llvm.org/D11725





More information about the llvm-commits mailing list