[llvm] r246277 - Rollback r246276 - Object: Teach llvm-ar to create symbol table for COFF short import files

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Fri Aug 28 01:03:01 2015
New Revision: 246277

URL: http://llvm.org/viewvc/llvm-project?rev=246277&view=rev
Log:
Rollback r246276 - Object: Teach llvm-ar to create symbol table for COFF short import files

This change caused a test for llvm-readobj to fail.


Removed:
    llvm/trunk/test/Object/Inputs/coff-short-import-code
    llvm/trunk/test/Object/Inputs/coff-short-import-data
Modified:
    llvm/trunk/lib/Object/SymbolicFile.cpp
    llvm/trunk/test/Object/archive-symtab.test

Modified: llvm/trunk/lib/Object/SymbolicFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/SymbolicFile.cpp?rev=246277&r1=246276&r2=246277&view=diff
==============================================================================
--- llvm/trunk/lib/Object/SymbolicFile.cpp (original)
+++ llvm/trunk/lib/Object/SymbolicFile.cpp Fri Aug 28 01:03:01 2015
@@ -11,58 +11,14 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "llvm/Object/COFF.h"
 #include "llvm/Object/IRObjectFile.h"
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/SymbolicFile.h"
-#include "llvm/Support/COFF.h"
 #include "llvm/Support/MemoryBuffer.h"
 
 using namespace llvm;
 using namespace object;
 
-// COFF short import file is a special kind of file which contains
-// only symbol names for DLL-exported symbols. This class implements
-// SymbolicFile interface for the file.
-namespace {
-class COFFImportFile : public SymbolicFile {
-public:
-  COFFImportFile(MemoryBufferRef Source)
-      : SymbolicFile(sys::fs::file_magic::coff_import_library, Source) {}
-
-  void moveSymbolNext(DataRefImpl &Symb) const override { ++Symb.p; }
-
-  std::error_code printSymbolName(raw_ostream &OS,
-                                  DataRefImpl Symb) const override {
-    if (Symb.p == 1)
-      OS << "__imp_";
-    OS << StringRef(Data.getBufferStart() + sizeof(coff_import_header));
-    return std::error_code();
-  }
-
-  uint32_t getSymbolFlags(DataRefImpl Symb) const override {
-    return SymbolRef::SF_Global;
-  }
-
-  basic_symbol_iterator symbol_begin_impl() const override {
-    return BasicSymbolRef(DataRefImpl(), this);
-  }
-
-  basic_symbol_iterator symbol_end_impl() const override {
-    DataRefImpl Symb;
-    Symb.p = isCode() ? 2 : 1;
-    return BasicSymbolRef(Symb, this);
-  }
-
-private:
-  bool isCode() const {
-    auto *Import = reinterpret_cast<const coff_import_header *>(
-        Data.getBufferStart());
-    return Import->getType() == llvm::COFF::IMPORT_CODE;
-  }
-};
-} // anonymous namespace
-
 SymbolicFile::SymbolicFile(unsigned int Type, MemoryBufferRef Source)
     : Binary(Type, Source) {}
 
@@ -98,10 +54,9 @@ ErrorOr<std::unique_ptr<SymbolicFile>> S
   case sys::fs::file_magic::macho_dynamically_linked_shared_lib_stub:
   case sys::fs::file_magic::macho_dsym_companion:
   case sys::fs::file_magic::macho_kext_bundle:
+  case sys::fs::file_magic::coff_import_library:
   case sys::fs::file_magic::pecoff_executable:
     return ObjectFile::createObjectFile(Object, Type);
-  case sys::fs::file_magic::coff_import_library:
-    return std::unique_ptr<SymbolicFile>(new COFFImportFile(Object));
   case sys::fs::file_magic::elf_relocatable:
   case sys::fs::file_magic::macho_object:
   case sys::fs::file_magic::coff_object: {

Removed: llvm/trunk/test/Object/Inputs/coff-short-import-code
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Inputs/coff-short-import-code?rev=246276&view=auto
==============================================================================
Binary file - no diff available.

Removed: llvm/trunk/test/Object/Inputs/coff-short-import-data
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Inputs/coff-short-import-data?rev=246276&view=auto
==============================================================================
Binary file - no diff available.

Modified: llvm/trunk/test/Object/archive-symtab.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/archive-symtab.test?rev=246277&r1=246276&r2=246277&view=diff
==============================================================================
--- llvm/trunk/test/Object/archive-symtab.test (original)
+++ llvm/trunk/test/Object/archive-symtab.test Fri Aug 28 01:03:01 2015
@@ -99,16 +99,6 @@ MACHO-NEXT: 0000000000000000 t _bar
 MACHO-NEXT: 0000000000000001 T _foo
 MACHO-NEXT: 0000000000000002 T _main
 
-RUN: rm -f %t.a
-RUN: llvm-ar --format=gnu rcsU %t.a %p/Inputs/coff-short-import-code %p/Inputs/coff-short-import-data
-RUN: llvm-nm -M %t.a | FileCheck --check-prefix=COFF-SHORT-IMPORT %s
-
-COFF-SHORT-IMPORT:      Archive map
-COFF-SHORT-IMPORT-NEXT: _foo in coff-short-import-code
-COFF-SHORT-IMPORT-NEXT: __imp__foo in coff-short-import-code
-COFF-SHORT-IMPORT-NEXT: _bar in coff-short-import-data
-COFF-SHORT-IMPORT-NOT:  __imp__bar in coff-short-import-data
-
 Test that we pad the symbol table so that it ends in a multiple of 4 bytes:
 8 + 60 + 36 == 104
 RUN: rm -f %t.a