[PATCH] D12001: Implement __emutls_get_address

[Dan Albert via llvm-commits]

danalbert added inline comments.

================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:44
@@ -43,2 +43,3 @@
   divxc3.c
+  emutls.c
   enable_execute_stack.c
----------------
compnerd wrote:
> Please don't add this to GENERIC_SOURCES.  This is really not applicable to all targets.  It uses pthread, so it can't be used on say Windows.
> 
> This makes me wonder if this actually belongs in the compiler builtins in the first place.
GCC keeps it in libgcc, and it's a function that's only ever emitted by the compiler as a replacement for `__thread`. Seems like this is the right place to me. A windows equivalent could be implemented as well, but perhaps it's best to just wrap all this in an `#if !defined(_WIN32)` for now.


http://reviews.llvm.org/D12001