[PATCH] D12293: Rework of the interface to enable shrink wrapping

[hfinkel@anl.gov via llvm-commits]

hfinkel added a comment.

Please take care of Quentin's "nitpicks", otherwise, LGTM too. Thanks!


================
Comment at: include/llvm/Target/TargetFrameLowering.h:146
@@ +145,3 @@
+  /// handle shrink wrapping.
+  virtual bool targetSupportsShrinkWrapping(const MachineFunction &MF) const {
+    return false;
----------------
qcolombet wrote:
> Maybe enableShrinkWrapping?
> “Supports" is kind of misleading because for instance X86 supports it, but it does not enabled it by default yet.
> 
> (Personally, I would not repeat target in the method name, but I see that are precedence :).)
I agree, enableShrinkWrapping seems good.



http://reviews.llvm.org/D12293