[PATCH] D11547: AliasSetTracker "fixme" fix - using mod/ref information for UnknownInstr

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Analysis/AliasSetTracker.cpp:116
@@ +115,3 @@
+  // upgrading access if existing UnknownInst has ModRef with new pointer
+  switch (MR) {
+  case MRI_NoModRef: break;
----------------
This is not your fault, but seems silly. ModRefInfo in AliasAnalysis.h and AccessLattice in AliasSetTracker.h are the *same* enum (modulo the names). We should just fix that (make AccessLattice == ModRefInfo), and eliminate the need for this switch statement.

If you don't want to do that first, please add a FIXME.



http://reviews.llvm.org/D11547