[PATCH] D12383: Teach LVI to look through Phi nodes when trying to prove a predicate

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

Aside from the couple of things on which Sanjoy commented, LGTM.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:1297
@@ +1296,3 @@
+          // all inputs. 
+          auto mergeResults = [](Tristate Baseline, Tristate Result) {
+            return Baseline == Result ? Baseline : Unknown;
----------------
Not really sure it is worth defining a simple one-line lambda function that is only used once, but if you think it makes the code more readable, then I won't object.


http://reviews.llvm.org/D12383