[PATCH] D12246: [NVPTX] change threading intrinsics from noduplicate to convergent

[Owen Anderson via llvm-commits]

Would it be possible to split the JumpThreading change from the NVPTX change?

—Owen

> On Aug 24, 2015, at 12:15 PM, Jingyue Wu <jingyue at google.com> wrote:
> 
> jingyue accepted this revision.
> This revision is now accepted and ready to land.
> 
> ================
> Comment at: test/CodeGen/NVPTX/convergent-syncthreads.ll:3
> @@ +2,3 @@
> +
> +; Make sure the call to syncthreads is not duplicate here by the LLVM
> +; optimizations, because it has the convergent attribute set.
> ----------------
> I understand that you are checking against JumpThreading duplicating syncthreads, but the wording is inaccurate. 
> 
> The convergent attribute restricts the compiler so that it moves a convergent instruction only to a control-equivalent location. It does _not_ prevent LLVM from duplicating convergent instructions. 
> 
> 
> http://reviews.llvm.org/D12246
> 
> 
>