[PATCH] D12153: Support inline functions symbolization in Addr2Line symbolizer.
Alexey Samsonov via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 13:19:00 PDT 2015
samsonov added a comment.
Sorry if I'm being overly nitpicky, but I don't understand why you've moved this logic away from Addr2LinePool - I actually preferred when the subclass was responsible for providing correct command to `SendCommand` and parsing its result accordingly...
================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:226
@@ +225,3 @@
+ FIRST_32_SECOND_64(UINT32_MAX, UINT64_MAX));
+ command = internal_strncat(command, dummy_address_, kBufferSize);
+ }
----------------
This is wrong - how could you know if the buffer for `command` has sufficient size?
http://reviews.llvm.org/D12153
More information about the llvm-commits
mailing list