[llvm] r245996 - WebAssembly: add small FIXME for AsmPrinter.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 13:02:54 PDT 2015


On 26 August 2015 at 18:15, JF Bastien <jfb at google.com> wrote:
> On Wed, Aug 26, 2015 at 11:38 AM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>
>> > I'm not sure I understand what you're proposing I do (or avoid doing)
>> > exactly. Could you elaborate?
>>
>> The use of comments to opt out of some features. Take a look at what
>> is done for .size for example.
>
>
> You mean hasDotTypeDotSizeDirective?

Yes. The general idea of the MC layer is that it sees the same calls
when doing direct emission and when going via assembly. Printing a
comment instead of a real directive breaks that.

I understand that we don't have direct output of wasm bitcode or even
a parser of the text format, but it is nice to stay close to that
design.

Cheers,
Rafael


More information about the llvm-commits mailing list