[PATCH] D10674: Value profiling - patchset 3

[Betul Buyukkurt via llvm-commits]

betulb updated this revision to Diff 33338.
betulb added a comment.

In this revision:

- Removed the StringTable members from indexed reader and writer and made it a static member variable in the base reader class. This helped maintain a single StringTable across all reader instances and for the indexed writer as well.
- Removed the updateStringTableReferences call from the InstrProfWriter.
- Returned error if hash is not found in the HashKeyMap in the indexed profile file reader. Because all the strings are expected to be in the Keys of OnDiskChainedItetableHashTable, not finding a hash entry should be processed as error.
- Added debug output for hash collisions.


http://reviews.llvm.org/D10674

Files:
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfIndexed.h
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/CoverageMappingTest.cpp
  unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10674.33338.patch
Type: text/x-patch
Size: 26420 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150827/9cb94138/attachment-0001.bin>