[PATCH] D12216: Cleaning up LLVM IR mode for Emacs

[Ramkumar Ramachandra via llvm-commits]

artagnon accepted this revision.
artagnon added a comment.
This revision is now accepted and ready to land.

LGTM, with some minor doubts.


================
Comment at: utils/emacs/llvm-mode.el:11
@@ -10,2 +10,3 @@
 
-(defvar llvm-mode-syntax-table nil
+(defvar llvm-mode-syntax-table
+  (let ((table (make-syntax-table)))
----------------
I _think_ this is okay.

================
Comment at: utils/emacs/llvm-mode.el:72
@@ -116,3 +71,3 @@
 ;;;###autoload
-(defun llvm-mode ()
+(define-derived-mode llvm-mode llvm-mode-prog-mode "LLVM"
   "Major mode for editing LLVM source files.
----------------
A good change, for sure.


http://reviews.llvm.org/D12216