[PATCH] D12202: Add Support for Small Size Reductions

[James Molloy via llvm-commits]

jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

LGTM, with the comment changes requested below.

Cheers!

James


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:197
@@ +196,3 @@
+  /// Returns true if the recurrence kind is an arithmetic kind.
+  static bool isArithmeticRecurrenceKind(RecurrenceKind Kind);
+
----------------
Hi,

OK, so lets keep the function name but could you please explain in a comment?

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:3340
@@ +3339,3 @@
+                     ? Builder.CreateSExt(Trunc, VecTy)
+                     : Builder.CreateZExt(Trunc, VecTy);
+        for (Value::user_iterator UI = RdxExitVal[part]->user_begin();
----------------
This isn't ideal, but I don't really want to add feature creep to this review. Could you add a fixme saying what the ideal would be?


http://reviews.llvm.org/D12202