[PATCH] D12395: [compiler-rt] [TSan] Enable TSan for AArch64/42-bit VMA

[Dmitry Vyukov via llvm-commits]

dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM when you fix nits in the test


================
Comment at: test/tsan/test.h:46
@@ +45,3 @@
+#elif defined(__aarch64__)
+  // AArch64 currently has 3 different VMA (39, 42, and 48 bits) and it require
+  // different pointer size to match the diagnostic message.
----------------
s/require/requires/

================
Comment at: test/tsan/test.h:48
@@ +47,3 @@
+  // different pointer size to match the diagnostic message.
+  const char *format = NULL;
+  unsigned long vma = (unsigned long)__builtin_frame_address(0);
----------------
s/NULL/0/ for consistency with the rest of tsan code

================
Comment at: test/tsan/test.h:53
@@ +52,3 @@
+    format = "0x%010lx";
+  else if (vma == 42)
+    format = "0x%011lx";
----------------
in the comment you say 39, 42 and 48, but here you handle only 39 and 42
do
  else {
    fprintf(stderr, "unsupported vma: %ul\n", vma);
    exit(1);
  }

better than crash with format==0


http://reviews.llvm.org/D12395