[PATCH] D12391: Fixed a bug that edge weights are not assigned correctly when lowering switch statement.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 17:31:41 PDT 2015


congh added inline comments.

================
Comment at: test/CodeGen/X86/switch-edge-weight.ll:6
@@ +5,3 @@
+
+; CHECK: BB#4:
+; CHECK: Successors according to CFG: BB#1(10) BB#6(10)
----------------
hans wrote:
> Please add a CHECK-LABEL and move this into or after the @test function.
> 
> The alloca, store and load, etc. seem unnecessary. Can the test just switch on the function parameter?
Done. I have simplified the function as suggested by you (previously I just copies it from another test case but I should look for a simplest one).

Thank you!


http://reviews.llvm.org/D12391





More information about the llvm-commits mailing list