[PATCH] D12305: [ASan] More ASAN_OPTIONS churn: use %env_asan_opts where applicable.

[Alexey Samsonov via llvm-commits]

Thank you!

On Wed, Aug 26, 2015 at 3:26 PM, Reid Kleckner <rnk at google.com> wrote:

> On Tue, Aug 25, 2015 at 11:55 AM, Alexey Samsonov via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>> On Tue, Aug 25, 2015 at 9:19 AM, Reid Kleckner <rnk at google.com> wrote:
>>
>>> rnk accepted this revision.
>>> rnk added a comment.
>>> This revision is now accepted and ready to land.
>>>
>>> lgtm with the updated xfail. Everything else passes.
>>>
>>>
>>> ================
>>> Comment at: test/asan/TestCases/suppressions-interceptor.cc:8-9
>>> @@ -7,4 +7,4 @@
>>>
>>>  // FIXME: Windows symbolizer needs work to make this pass.
>>>  // XFAIL: android,win32
>>>
>>> ----------------
>>> You can remove the win32 XFAIL and FIXME here, the test passes with this
>>> change. I must have misdiagnosed this issue when I was porting the test
>>> suite. =/
>>>
>>> The good news is that it passes. :)
>>>
>>
>> I have removed XFAIL and the test failed on the buildbot:
>> http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8908/steps/run%20tests/logs/stdio
>> Any ideas?
>>
>
> The bot uses the gnuwin32 tools, which we recommend. For mostly historical
> reasons, I'm using the Cygwin Unix tools. Apparently the gnuwin32 version
> of echo produces DOS line ending text. The sanitizer suppression code
> wasn't expecting that. I fixed it in r246096.
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150826/50e48455/attachment.html>