[PATCH] D12345: [Reassociate]: Add intermediate subtract instructions created while negating to be redone later for more reassociate opportunities

Aditya Nandakumar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 11:27:02 PDT 2015


aditya_nandakumar added a comment.

Thanks Chad. I will fix the comments shortly.
I think I might have found another convergence issue with reassociate. I expect when the pass finishes, running reassociate again should not make any changes (the output should already be in canonicalized form - please correct me if this is not a valid expectation). It currently takes three runs of reassociate for the output to converge while running secondary.ll (above change). Should this also be tackled in this change?


Repository:
  rL LLVM

http://reviews.llvm.org/D12345





More information about the llvm-commits mailing list