[PATCH] D12285: [LV] Switch to using canonical induction variables.

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 11:21:45 PDT 2015


Sure. If we have a single, non canonical phi, and we create a canonical
one, then we'll end up with one phi with a constant add inside the loop.

I would have expected it to be instcombine that would take that add and
thread it up before the loop.


Having said that, instcombine doesn't look at loop depths so yes, it would
probably be LSR (or indvars?)

James
On Wed, 26 Aug 2015 at 18:54, Adam Nemet via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> anemet added a comment.
>
> In http://reviews.llvm.org/D12285#232977, @jmolloy wrote:
>
> > I have a patch in my queue to remove ExtendedIdx later - I can merge
> that into this one.
>
>
> Up to you, just wanted to make sure it does not stay there.
>
> Can you please also address my question regarding LSR vs. InstCombine?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D12285
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150826/84dafb73/attachment.html>


More information about the llvm-commits mailing list