[PATCH] D12332: [Sanitizers] Make abort_on_error common flag.

[Kuba Brecka via llvm-commits]

kubabrecka added a comment.

Alexey, there are two test failures with this change.  The test `sanitizer_common/TestCases/Darwin/abort_on_error.cc` fails with

  Undefined symbols for architecture i386:
    "__sanitizer::Die()", referenced from:
        _main in abort_on_error-4d1da3.o
  ld: symbol(s) not found for architecture i386

because `__sanitizer::Die()` is not an exported symbol.  The second failure is in `sanitizer_common/TestCases/options-include.cc`:

  Exit Code: 1
  Error: Abort trap: 6

This is because the test overrides %tool_options without inheriting the default ones (like we do with `%env_asan_opts` in ASan lit tests).  Therefore the test crashes on OS X instead of just quitting with a non-zero exit code.


http://reviews.llvm.org/D12332