[PATCH] D12349: [SPARC] Fix stupid oversight in stack realignment support.

[Chandler Carruth via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Looks good with a comment update below.


================
Comment at: lib/Target/Sparc/SparcFrameLowering.cpp:121-123
@@ -120,1 +120,5 @@
 
+  // Add the extra call frame stack size, if needed (this would've
+  // been done by PrologEpilogInserter.cpp, except that we have
+  // targetHandlesStackFrameRounding returning true.)
+  if (MFI->adjustsStack() && hasReservedCallFrame(MF))
----------------
I wouldn't reference the hook here. Instead, I would explain the why. Clearly (according to the spec of the API) to do this here your target has to set the hook correctly. But why does SPARC handle alignment this way.


http://reviews.llvm.org/D12349