[PATCH] D12353: [WinEH] Update coloring to handle nested cases cleanly

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 23:24:53 PDT 2015


majnemer added inline comments.

================
Comment at: test/CodeGen/WinEH/wineh-cloning.ll:269-270
@@ +268,4 @@
+; %inner is a cleanup which appears both as a child of
+; %left and as a child of %right.  Since statically we
+; need each funclet to have a single parent, we need to
+; clone the entire %inner funclet so we can have one
----------------
When you say each funclet needs to have a single parent, do you mean that it must have a single non-invoke predecessor?  It will be quite common for a set of invokes in a try-block to have the same unwind destination.


http://reviews.llvm.org/D12353





More information about the llvm-commits mailing list