[llvm] r245982 - WebAssembly: comment out .globl when printing textual assembly

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 17:00:22 PDT 2015


On Tue, Aug 25, 2015 at 3:23 PM, JF Bastien via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> @@ -52,5 +52,8 @@ WebAssemblyMCAsmInfo::WebAssemblyMCAsmIn
>    // For now, WebAssembly does not support exceptions.
>    ExceptionsType = ExceptionHandling::None;
>
> +  WeakDirective = "\t;; .weak\t";
> +  GlobalDirective = "\t;; .globl\t";

Ideally, we should modify the base AsmPrinter class to give us more
flexibility here, rather than just hacking around it. For now, could
you add a big FIXME comment about this?

Dan


More information about the llvm-commits mailing list