[PATCH] D12339: [CMake] Add OBJECT_LIBS option to add_compiler_rt_runtime, and refactored asan call site to use it.

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM (please address comments below).


================
Comment at: cmake/Modules/AddCompilerRT.cmake:54
@@ +53,3 @@
+  foreach(lib ${ARGN})
+    set(${output} ${${output}} $<TARGET_OBJECTS:${lib}.${suffix}>)
+  endforeach()
----------------
Please use list(APPEND) here

================
Comment at: cmake/Modules/AddCompilerRT.cmake:69
@@ -59,3 +68,3 @@
 #                         LINK_LIBS <linked libraries> (only for shared library)
 #                         PARENT_TARGET <convenience parent target>)
 function(add_compiler_rt_runtime name type)
----------------
Please describe OBJECT_LIBS here.

================
Comment at: lib/asan/CMakeLists.txt:124
@@ -130,1 +123,3 @@
+  
     set(ASAN_COMMON_RUNTIME_OBJECTS
+      RTInterception
----------------
ASAN_COMMON_RUNTIME_OBJECT_LIBS


http://reviews.llvm.org/D12339