[PATCH] D12335: Repress sanitization on User dtor.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 14:37:17 PDT 2015


eugenis added inline comments.

================
Comment at: include/llvm/IR/User.h:75
@@ -74,4 +74,3 @@
 public:
-  ~User() override {
-  }
+  LLVM_NO_SANITIZE_ATTRIBUTE ~User() override {}
   /// \brief Free memory allocated for User and Use objects.
----------------
Please add a brief comment describing the problem and referencing the bug.


================
Comment at: include/llvm/Support/Compiler.h:323
@@ +322,3 @@
+/// \brief Skip memory sanitization for this function.
+#ifdef MEMORY_SANITIZER
+# define LLVM_NO_SANITIZE_ATTRIBUTE __attribute__((no_sanitize_memory))
----------------
There is no "MEMORY_SANITIZER" definition.
Merge this with the block below.
Call it LLVM_NO_SANITIZE_MEMORY_ATTRIBUTE.


http://reviews.llvm.org/D12335





More information about the llvm-commits mailing list