[PATCH] D12302: Comparing operands should not require the same ValueID

Tue Aug 25 13:59:45 PDT 2015

jfb added a comment.

Ugh... sorry for more comments... I think you should separate each test into its own .ll file: as is they check that merging occurred, but the tests doesn't validate *what* got merged! Having them in separate files would make that obvious and potentially catch tricky bugs.

I'm good after that!

================
Comment at: test/Transforms/MergeFunc/merge-const-ptr-and-int.ll:2
@@ +1,3 @@
+; RUN: opt -mergefunc -S < %s | FileCheck %s
+; RUN: opt -mergefunc -S < %s | FileCheck -check-prefix=CHECKNOT %s
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
----------------
Bikeshed: CHECKNOT-NOT is a bit weird. MERGED-NOT would be nicer.

http://reviews.llvm.org/D12302