[PATCH] D10674: Value profiling - patchset 3

[Xinliang David Li via llvm-commits]

>> ================
>> Comment at: lib/ProfileData/InstrProfWriter.cpp:139
>> @@ +138,3 @@
>> +InstrProfWriter::addRecord(InstrProfRecord &I) {
>> +  I.updateStringTableReferences(StringTable);
>> +  auto &ProfileDataMap = FunctionData[I.Name];
>> ----------------
>> Is this needed? I don't see StringTable is written out anywhere.
>
> Both raw and indexed readers maintain their own StringTable, so the
> indirect call target value entries arrive pointing always to the reader's
> string table. This routine would translate all the relevant value entries
> to point to the entries in the writer's StringTable.

ok. The reader's stringtable may be reclaimed before writer writes out the data.

David

>
> Thanks,
> -Betul
>
>> http://reviews.llvm.org/D10674
>
>
>
>